[Webkit-unassigned] [Bug 40932] Separate line-ending conversion code from BlobItem for code cleanup

Tue Jul 13 14:59:15 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40932

Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61139|review?                     |review+
               Flag|                            |

--- Comment #5 from Jian Li <jianli at chromium.org>  2010-07-13 14:59:15 PST ---
(From update of attachment 61139)
r=me

Looks good except the following minor comments. Please address these issue before you land the patch.

WebCore/platform/text/LineEnding.h:38
 +  using WTF::CString;
Please try to avoid using "using" directive in the header file if possible.

WebCore/platform/text/LineEnding.h:51
 +  // Normalize all line-endings in the given string to the native line-endings
Please end the comment with period.

WebCore/platform/text/LineEnding.h:52
 +  // (e.g. normalize to CRLF on Windows etc).
Better to also mention that we normalize to LF for all other platforms, including Linux and MacOSX.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.