[Webkit-unassigned] [Bug 41441] Add a target URL parameter to the createView and createWindow method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 10:28:04 PDT 2010


--- Comment #14 from Johnny Ding <jnd at chromium.org>  2010-07-09 10:28:03 PST ---
(In reply to comment #13)
> (From update of attachment 61050 [details])
> WebCore/loader/FrameLoader.h:125
>  +      Frame* createWindow(FrameLoader* frameLoaderForFrameLookup, const FrameLoadRequest&, const WindowFeatures&, const KURL&, bool&);
> please do not remove the "created" parameter name.  that was helpful
> documentation for the meaning of the bool out parameter.  the rule
> in webkit is to leave parameters unnamed if the type name is sufficient
> to document its purpose.  in this case, i think you should also give
> the KURL parameter a name.  targetURL seems good since you are using
> that elsewhere.
> actually, it just occurred to me:  why do we need to pass completedURL
> when we have the url stored in the frameRequest?  it should not be a
> different url.

Yes, ideally the targetURL should be as same as the URL in the frameRequest, but according to the comments in JSDOMWindowCustom.cpp, now  the code only passes the empty string for the URL. The reason is,  before loading the URL, we have to set up the opener, openedByDOM, and dialogArguments values. Also, to decide whether to use the URL we currently do an allowsAccessFrom call using the window we create, which can't be done before creating it. We'd have to resolve all those issues to pass the URL instead of "".

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list