[Webkit-unassigned] [Bug 41441] Add a target URL parameter to the createView and createWindow method

Fri Jul 9 10:09:24 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=41441

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61050|review?                     |review-
               Flag|                            |

--- Comment #13 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-09 10:09:24 PST ---
(From update of attachment 61050)
WebCore/loader/FrameLoader.h:125
 +      Frame* createWindow(FrameLoader* frameLoaderForFrameLookup, const FrameLoadRequest&, const WindowFeatures&, const KURL&, bool&);
please do not remove the "created" parameter name.  that was helpful
documentation for the meaning of the bool out parameter.  the rule
in webkit is to leave parameters unnamed if the type name is sufficient
to document its purpose.  in this case, i think you should also give
the KURL parameter a name.  targetURL seems good since you are using
that elsewhere.

actually, it just occurred to me:  why do we need to pass completedURL
when we have the url stored in the frameRequest?  it should not be a
different url.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.