[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898





--- Comment #12 from chris fleizach <cfleizach at apple.com>  2010-07-09 09:24:52 PST ---

> Hmm... I found another problem when trying to implement this (I mean, apart from the issue of having to emit the signal before deleting text):
> 
> For properly emitting this signal, I need to know both the offset and the length of the piece of text being inserted or deleted, which is a kind of information I do have clearly available when implementing this through the notifyAccessibility() method in InsertIntoTextNodeCommand, DeleteFromTextNodeCommand, InsertNodeBeforeCommand and AppendNodeCommand.
> 
> However, when I try to extract this information from AXObjectCache::postPlatformNotification(), I'm having a hard time to do it so since that information seems to have got lost up in the backtrace, far before calling to AXObjectCache::postNotification() in the first place, and I wonder if, given this requirements, perhaps after all the initial approach of doing this more ad-hoc in WebCore/editing could be the right way to do. Or perhaps there's actually a way to know both the offset and length for insertions and deletions from AXObjectCache that I'm missing... don't know yet.
> 
> Perhaps, this is the same rationale behind the WebCore/editing/gtk/SelectionControllerGtk.cpp file, used to properly emit the text-caret-moved signal... Xan, could you please comment a bit on this?
> 
> Thanks

On the Mac side, its up to the screen reader to determine what has changed. the screen reader is only notified that the value has changed (that design decision was made a long time ago). 

If however, GTK needs more explicit information then your method of adding accessibility calls in each specific place is a reasonable approach, but I think you should either
a) make specific methods for each type of text iteration in AXObjectCache that handles it
b) make a new kind of AXNotification for each type of thing you need
    if need be, you might have to add a parameter argument to one of the postNotification methods

i'd just like to see the code be in a common WebCore method so that other platforms could use if necessary

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.