[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898





--- Comment #11 from Mario Sanchez Prada <msanchez at igalia.com>  2010-07-09 01:40:34 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > Great. I think the existing value change notifications are pretty good 
> > chokepoints for handling text changes, but there might be missing cases.
> 
> Indeed. Actually I've just found there's a nice function -already GTK specific- 
> called postPlatformNotification() that looks like the way to go, at least for 
> notifying of text insertions (I'm not so sure about deletions as typically, at 
> least in gtk & clutter, those notifications should be emitted *before* the 
> actual deletion happen).
> 
> Let's see how it works.

Hmm... I found another problem when trying to implement this (I mean, apart from the issue of having to emit the signal before deleting text):

For properly emitting this signal, I need to know both the offset and the length of the piece of text being inserted or deleted, which is a kind of information I do have clearly available when implementing this through the notifyAccessibility() method in InsertIntoTextNodeCommand, DeleteFromTextNodeCommand, InsertNodeBeforeCommand and AppendNodeCommand.

However, when I try to extract this information from AXObjectCache::postPlatformNotification(), I'm having a hard time to do it so since that information seems to have got lost up in the backtrace, far before calling to AXObjectCache::postNotification() in the first place, and I wonder if, given this requirements, perhaps after all the initial approach of doing this more ad-hoc in WebCore/editing could be the right way to do. Or perhaps there's actually a way to know both the offset and length for insertions and deletions from AXObjectCache that I'm missing... don't know yet.

Perhaps, this is the same rationale behind the WebCore/editing/gtk/SelectionControllerGtk.cpp file, used to properly emit the text-caret-moved signal... Xan, could you please comment a bit on this?

Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.