[Webkit-unassigned] [Bug 34953] Implement DEFINE_STUB_FUNCTION for WinCE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34953





--- Comment #18 from Ismail "cartman" Donmez <ismail at namtrac.org>  2010-07-08 09:08:25 PST ---
(In reply to comment #17)
> Created an attachment (id=60895)
 --> (https://bugs.webkit.org/attachment.cgi?id=60895) [details]
> alternative Patch (only JITStubs.cpp, no qmake changes)
> 
> (In reply to comment #15)
> > The patch looks good to me.
> > I have only one question. Why the JITSTUBS_OFFSET is hard-coded in the pro file? Could not we use a better approach? like parsing it from JITStups.cpp or Platform.h with the same script?
> Maybe we can commit only the changes in JITStubs.cpp in the meantime?
> 
> As i know Nokia ships the sourcecode with already generated files. This means that DerivedSources.pro should generate GeneratedJITStubs_RVCT.h, 
> GeneratedJITStubs_MSVC32.asm and GeneratedJITStubs_MSVC64.asm at the same time.

Parsing the offset value from Platform.h would not be so hard, I can try a fix for that if its desired.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.