[Webkit-unassigned] [Bug 34953] Implement DEFINE_STUB_FUNCTION for WinCE

Thu Jul 8 09:01:16 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=34953

Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60895|                            |review?, commit-queue?
               Flag|                            |

--- Comment #17 from Patrick R. Gansterer <paroga at paroga.com>  2010-07-08 09:01:15 PST ---
Created an attachment (id=60895)
 --> (https://bugs.webkit.org/attachment.cgi?id=60895)
alternative Patch (only JITStubs.cpp, no qmake changes)

(In reply to comment #15)
> The patch looks good to me.
> I have only one question. Why the JITSTUBS_OFFSET is hard-coded in the pro file? Could not we use a better approach? like parsing it from JITStups.cpp or Platform.h with the same script?
Maybe we can commit only the changes in JITStubs.cpp in the meantime?

As i know Nokia ships the sourcecode with already generated files. This means that DerivedSources.pro should generate GeneratedJITStubs_RVCT.h, 
GeneratedJITStubs_MSVC32.asm and GeneratedJITStubs_MSVC64.asm at the same time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.