[Webkit-unassigned] [Bug 32605] Regression: Selection anchor + focus swap when arrow keys after setBaseAndExtent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32605





--- Comment #14 from Darin Adler <darin at apple.com>  2010-07-08 08:17:18 PST ---
(From update of attachment 60770)
> -        m_frame->selection()->setSelection(newSelection, m_frame->selectionGranularity());
> +        m_frame->selection()->setSelection(newSelection, m_frame->selectionGranularity(), false);

This is a classic example of why we don't use boolean arguments when constants are passed. This patch would be considerably better if the argument used an enum with good names instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.