[Webkit-unassigned] [Bug 32605] Regression: Selection anchor + focus swap when arrow keys after setBaseAndExtent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 11:35:48 PDT 2010


--- Comment #15 from Ojan Vafai <ojan at chromium.org>  2010-07-08 11:35:47 PST ---
(In reply to comment #14)
> (From update of attachment 60770 [details])
> > -        m_frame->selection()->setSelection(newSelection, m_frame->selectionGranularity());
> > +        m_frame->selection()->setSelection(newSelection, m_frame->selectionGranularity(), false);
> This is a classic example of why we don't use boolean arguments when constants are passed. This patch would be considerably better if the argument used an enum with good names instead.

enum Directionality { DirectionalityNone, DirectionalityAware }; was the best I could come up with. Does that work?

This patch has changed enough since the r+ from Adam, that I think it's worth getting another review.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list