[Webkit-unassigned] [Bug 39625] [Qt] Sending a QInputMethodEvent::Selection event forces the Editor to go into Composition mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 5 11:41:16 PDT 2010


--- Comment #12 from Robert Hogan <robert at webkit.org>  2010-07-05 11:41:16 PST ---
(In reply to comment #11)
> (From update of attachment 57408 [details])
> Your current patch is an improvement on the current situation so r=me. If Simon has more comments we can fix that in a follow up.
> A bit of comments in the code would have been nice though
> WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1479
>  +      QCOMPARE(value, QString("Qit"));
> Is this a right change? Seems like an error

Good question! My note in the changelog is about this:

"Remove the test in tst_qwebpage that performs a pre-edit composition and checks that surrounding text is unaffected. If we're in composition mode and change the composition, even without committing it, we will return the surrounding the text of the latest composition. So the expectations of this test seems wrong."

That's my two cents - so hopefully Simon can say if it's right or not.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list