[Webkit-unassigned] [Bug 39625] [Qt] Sending a QInputMethodEvent::Selection event forces the Editor to go into Composition mode

Sat Jul 3 07:40:05 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39625

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57408|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-07-03 07:40:05 PST ---
(From update of attachment 57408)
Your current patch is an improvement on the current situation so r=me. If Simon has more comments we can fix that in a follow up.

A bit of comments in the code would have been nice though

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1479
 +      QCOMPARE(value, QString("Qit"));
Is this a right change? Seems like an error

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.