[Webkit-unassigned] [Bug 41441] Add a target URL parameter to the createView and createWindow method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41441





--- Comment #8 from Johnny Ding <jnd at chromium.org>  2010-07-01 20:27:07 PST ---
Thanks, Darin! All done!

(In reply to comment #6)
> (From update of attachment 60230 [details])
> > +    KURL completedUrl =
> > +        url.isEmpty() ? KURL(ParsedURLString, "") : completeURL(url);
> 
> It should be completedURL, not completedUrl. See the coding style document and note what you yourself did below with targetURL.
> 
> I know you just moved the code, but is KURL(ParsedURLString, "") better than KURL()? Is it different at all?
> 
> >      Frame* createWindow(FrameLoader* frameLoaderForFrameLookup, const FrameLoadRequest&, const WindowFeatures&, bool& created);
> > +    // Another version of createWindow which passes the target URL where the created window will be navigated to.
> > +    Frame* createWindow(FrameLoader* frameLoaderForFrameLookup, const FrameLoadRequest&, const WindowFeatures&, const KURL& targetURL, bool& created);
> 
> Do we really need to have both of these? Can we change the callers to all call the new one? I don't like having an extra function here.
> 
> >          Page* createWindow(Frame*, const FrameLoadRequest&, const WindowFeatures&) const;
> > +        Page* createWindow(Frame*, const FrameLoadRequest&, const WindowFeatures&, const KURL&) const;
> 
> Do we really need to have both of these? Can we change the callers to all call the new one? I don't like having an extra function here.
> 
> Otherwise seems fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.