[Webkit-unassigned] [Bug 41441] Add a target URL parameter to the createView and createWindow method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 1 13:21:38 PDT 2010


--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-01 13:21:37 PST ---
(From update of attachment 60230)
 +  #include <wtf/UnusedParam.h>
you cannot have wtf includes from webkit api headers.
please just leave the parameter unnamed down below.

 +          virtual Page* createWindow(Frame* frame, const FrameLoadRequest& request, const WindowFeatures& features, const KURL& targetURL)
although it is painful, Sam reminded me recently that we should
make all ChromeClient and FrameLoaderClient methods pure virtual.
that way ports will fail to compile if they do not implement the
new methods.  this can help ports not get out of sync with the
methods that they need to be implementing.  arguably, they don't
need to be implementing this function, but it is better for us to
have a consistent policy that is easy to enforce.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list