[Webkit-unassigned] [Bug 34297] [Win] Fix a bug of round() with huge integral numbers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34297


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from TAMURA, Kent <tkent at chromium.org>  2010-01-31 18:35:59 PST ---
(In reply to comment #4)
> (From update of attachment 47665 [details])
> > +    if (!_finite(num))
> > +        return num;
> 
> Seems bad for performance to do this. Can't we just leave this out? It seems
> that infinity or NAN would be unchanged by the code below.

ok, removed.

> 
> > +    double tmp = ceil(num);
> 
> I think we can come up with a better name than "tmp" for this. I suggest
> "ceiling" or "integer"?

Renamed it to "integer".

Landed as r54121 <http://trac.webkit.org/changeset/54121>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.