[Webkit-unassigned] [Bug 34297] [Win] Fix a bug of round() with huge integral numbers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 14:25:51 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34297


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47665|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2010-01-29 14:25:50 PST ---
(From update of attachment 47665)
> +    if (!_finite(num))
> +        return num;

Seems bad for performance to do this. Can't we just leave this out? It seems
that infinity or NAN would be unchanged by the code below.

> +    double tmp = ceil(num);

I think we can come up with a better name than "tmp" for this. I suggest
"ceiling" or "integer"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list