[Webkit-unassigned] [Bug 34376] [Qt] Use Windows style on Maemo 5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34376


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47769|review?                     |review-
               Flag|                            |




--- Comment #5 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-01-31 15:45:12 PST ---
(From update of attachment 47769)
> +        [Qt] Use Windows style on Maemo 5

Better to refer it as "Use the fallback style...". Note that the fallback style
could be the application style if the Windows style can't be created (e.g. the
style plugin for that is missing or not available).

>  void RenderThemeQt::setPaletteFromPageClientIfExists(QPalette& palette) const
>  {
> +#ifdef Q_WS_MAEMO_5
> +    static QPalette lightGrayPalette(Qt::lightGray);
> +    palette = lightGrayPalette;
> +#else
>      // If the webview has a custom palette, use it
>      if (!m_page)
>          return;
> @@ -786,6 +795,7 @@ void RenderThemeQt::setPaletteFromPageClientIfExists(QPalette& palette) const
>      if (!pageClient)
>          return;
>      palette = pageClient->palette();
> +#endif

Why don't we have a quick return like in qStyle() patch above? That way, the
alternative code path is easier to spot.

r- for these minor issues, otherwise LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.