[Webkit-unassigned] [Bug 34376] [Qt] Use Windows style on Maemo 5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34376


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-01-31 07:09:21 PST ---
(In reply to comment #3)
> Because of:
> ../../../WebCore/platform/qt/RenderThemeQt.cpp:165: error: passing 'const
> WebCore::RenderThemeQt' as 'this' argument of 'QStyle*
> WebCore::RenderThemeQt::fallbackStyle()' discards qualifiers

Yes, but fallbackStyle and qStyle are things of the Qt port. The thing is that
fallbackStyle is not really const. So, with you patch you are "lying" that
qStyle is :-)

You could either change qStyle to not be const anymore, or - if the fallback
style doesn't change at runtime - move the fallback construction code to the
constructor and make both methods const.

I think that I would add
m_fallbackStyle = QStyleFactory::create(QLatin1String("windows"));
to the constructor. We need that anyway for painting menu list buttons

and change fallbackStyle to:

// for some widget painting, we need to fallback to Windows style
QStyle* RenderThemeQt::fallbackStyle() const
{
    return (m_fallbackStyle) ? m_fallbackStyle : QApplication::style();
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.