[Webkit-unassigned] [Bug 34069] REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34069





--- Comment #2 from MORITA Hajime <morrita at gmail.com>  2010-01-26 07:25:10 PST ---
Thanks for the investigation, Hamaji-san.
I don't have windows box...

> It seems eventSender.leapForward() actually waits on Windows? 
At a glance, the code appears to literally sleep.

in WebKitTools/DumpRenderTree/win/EventSender.cpp,

----
static JSValueRef leapForwardCallback(JSContextRef context, JSObjectRef
function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef
arguments[], JSValueRef* exception)
{
    if (argumentCount > 0) {
        msgQueue[endOfQueue].delay = JSValueToNumber(context, arguments[0],
exception);
    }
...
}

and 

void replaySavedEvents(HRESULT* oleDragAndDropReturnValue)
{
...
    if (msgQueue[startOfQueue].delay) {
        ::Sleep(msgQueue[startOfQueue].delay);
        msgQueue[startOfQueue].delay = 0;
    }
...
}

----

I guess it would take long time to run the test case,
and the case would be around timeout border,
timed out recently with small overhead added somewhere.

For this reason, I think making sleep time shorter is reasonable at this time, 
although further investigation to speedup windows layout test is required.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.