[Webkit-unassigned] [Bug 34070] New: Fix failure of webkit-patch unit test webkitpy.scm_unittest.SCMClassTests.test_error_handlers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34070

           Summary: Fix failure of webkit-patch unit test
                    webkitpy.scm_unittest.SCMClassTests.test_error_handler
                    s
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: eric at webkit.org, abarth at webkit.org


Following up on Eric Seidel's comment
<https://bugs.webkit.org/show_bug.cgi?id=32896#c10>, the changes introduced in
the patch for bug #32896 caused the method
webkitpy.scm_unittest.SCMClassTests.test_error_handlers to fail with the
following error:

======================================================================
ERROR: test_error_handlers (webkitpy.scm_unittest.SCMClassTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/scm_unittest.py",
line 150, in test_error_handlers
    self.assertRaises(OSError, run_command, command_does_not_exist)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/unittest.py",
line 336, in failUnlessRaises
    callableObj(*args, **kwargs)
  File
"/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/executive.py", line
70, in run_command
    return Executive().run_command(*args, **kwargs)
  File
"/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/executive.py", line
142, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File
"/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/webkitpy/executive.py", line
113, in default_error_handler
    raise error
ScriptError: Failed to run "['does_not_exist', 'invalid_option']" exit_code: 2

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.