[Webkit-unassigned] [Bug 27312] [XSSAuditor] Add support for header X-XSS-Protection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27312





--- Comment #7 from Daniel Bates <dbates at webkit.org>  2010-01-25 23:56:00 PST ---
I would prefer not use setTimeout as well.

>From both observation and briefly tracing through the code, the load event does
not seem to be fired on a scheduled redirect to about:blank. So, counting the
number of load events fired will not work because it will not reflect the
scheduled redirect. Moreover, the test fails if I do not wait for the redirect
to about:blank since the test result will have the content of the <iframe>
instead of being blank.

(In reply to comment #6)
> (From update of attachment 47316 [details])
> This looks pretty good.  One problem though:
> 
> + window.setTimeout(done, millisecondsToWait);
> 
> Don't want to use setTimeout to control when the test ends.  This will make the
> test flaky on slow bots, like ones running valgrind.
> 
> Instead, you should count how many times the load event for the frame fires. 
> It should fire a deterministic number of times.
> 
> Have you tried not waiting until done?  The load event for the main frame might
> be delayed until the iframe finishes all its loading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.