[Webkit-unassigned] [Bug 27312] [XSSAuditor] Add support for header X-XSS-Protection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27312


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47316|review?                     |review-
               Flag|                            |




--- Comment #6 from Adam Barth <abarth at webkit.org>  2010-01-25 02:44:17 PST ---
(From update of attachment 47316)
This looks pretty good.  One problem though:

+ window.setTimeout(done, millisecondsToWait);

Don't want to use setTimeout to control when the test ends.  This will make the
test flaky on slow bots, like ones running valgrind.

Instead, you should count how many times the load event for the frame fires. 
It should fire a deterministic number of times.

Have you tried not waiting until done?  The load event for the main frame might
be delayed until the iframe finishes all its loading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.