[Webkit-unassigned] [Bug 34074] Convert textarea-rows-cols.html to dumpAsText()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34074





--- Comment #6 from TAMURA, Kent <tkent at chromium.org>  2010-01-25 22:30:41 PST ---
(In reply to comment #5)
> (From update of attachment 47387 [details])
> Thanks for the fix! r+ assuming you'll address the comment below and combine
> patch v1 and v2 into a single patch.

Wow, It seems I have missed --amend.  I'll commit combined patch manually.

> > -shouldBeTrue('defaultHeight > 0');
> > -shouldBeTrue('defaultWidth > 0');
> 
> I guess we don't need to remove them?

Other assertions contain them implicitly. We may have them for readability, of
course. I'll revive them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.