[Webkit-unassigned] [Bug 34074] Convert textarea-rows-cols.html to dumpAsText()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 22:17:27 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34074


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47387|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Shinichiro Hamaji <hamaji at chromium.org>  2010-01-25 22:17:27 PST ---
(From update of attachment 47387)
Thanks for the fix! r+ assuming you'll address the comment below and combine
patch v1 and v2 into a single patch.

> -shouldBeTrue('defaultHeight > 0');
> -shouldBeTrue('defaultWidth > 0');

I guess we don't need to remove them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list