[Webkit-unassigned] [Bug 33986] HTMLInputElement::valueAsDate setter support for type=week.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33986


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from TAMURA, Kent <tkent at chromium.org>  2010-01-24 18:17:23 PST ---
Thank you for the review.

(In reply to comment #5)
> (From update of attachment 47174 [details])
> > +debug('Around Geregorian calendar starting year:');
> 
> Typo: "Geregorian".

Fixed.

> > +// Gregorian calendar started in 1582. We don't suuprot that year.
> 
> Typo: "suuprot".

Fixed.

> >      case Week: {
> > -        // Offset from January 1st to Monday of the ISO 8601's first week.
> > -        //   ex. If January 1st is Friday, such Monday is 3 days later.
> > -        int offsetTo1stWeekStart = 1 - dayOfWeek(m_year, 0, 1);
> > -        if (offsetTo1stWeekStart <= -4)
> > -            offsetTo1stWeekStart += 7;
> > -        return (dateToDaysFrom1970(m_year, 0, 1) + offsetTo1stWeekStart + (m_week - 1) * 7) * msPerDay;
> > +        return (dateToDaysFrom1970(m_year, 0, 1) + offsetTo1stWeekStart(m_year) + (m_week - 1) * 7) * msPerDay;
> >      }
> 
> Should get rid of the unneeded braces here.

Fixed.

Landed as r53787.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.