[Webkit-unassigned] [Bug 33986] HTMLInputElement::valueAsDate setter support for type=week.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33986


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47174|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-01-22 09:28:59 PST ---
(From update of attachment 47174)
> +debug('Around Geregorian calendar starting year:');

Typo: "Geregorian".

> +// Gregorian calendar started in 1582. We don't suuprot that year.

Typo: "suuprot".

>      case Week: {
> -        // Offset from January 1st to Monday of the ISO 8601's first week.
> -        //   ex. If January 1st is Friday, such Monday is 3 days later.
> -        int offsetTo1stWeekStart = 1 - dayOfWeek(m_year, 0, 1);
> -        if (offsetTo1stWeekStart <= -4)
> -            offsetTo1stWeekStart += 7;
> -        return (dateToDaysFrom1970(m_year, 0, 1) + offsetTo1stWeekStart + (m_week - 1) * 7) * msPerDay;
> +        return (dateToDaysFrom1970(m_year, 0, 1) + offsetTo1stWeekStart(m_year) + (m_week - 1) * 7) * msPerDay;
>      }

Should get rid of the unneeded braces here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.