[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #47 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-21 17:22:58 PST ---
Attachment 47162 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/plugins/gtk/PluginViewGtk.cpp:68:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/plugins/gtk/PluginViewGtk.cpp:69:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:70:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:71:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/plugins/gtk/PluginViewGtk.cpp:212:  dummy_w is incorrectly named. Don't
use underscores in your identifier names.  [readability/naming] [4]
WebCore/plugins/gtk/PluginViewGtk.cpp:213:  dummy_i is incorrectly named. Don't
use underscores in your identifier names.  [readability/naming] [4]
WebCore/plugins/gtk/PluginViewGtk.cpp:214:  dummy_ui is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/plugins/gtk/PluginViewGtk.cpp:232:  Use 0 instead of NULL. 
[readability/null] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:250:  Missing space before ( in if( 
[whitespace/parens] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:304:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:311:  Missing space before ( in if( 
[whitespace/parens] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:321:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:325:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:468:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:481:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:777:  Use 0 instead of NULL. 
[readability/null] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:794:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:844:  Use 0 instead of NULL. 
[readability/null] [5]
WebCore/plugins/gtk/PluginViewGtk.cpp:847:  One line control clauses should not
use braces.  [whitespace/braces] [4]
Total errors found: 19


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.