[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831





--- Comment #48 from Brian Tarricone <bjt23 at cornell.edu>  2010-01-21 17:50:28 PST ---
Sigh, ok...

(In reply to comment #47)
> WebCore/plugins/gtk/PluginViewGtk.cpp:794:  Tests for true/false,
> null/non-null, and zero/non-zero should all be done without equality
> comparisons.  [readability/comparison_to_zero] [5]

I'm not fixing this one, because the test is while checking a version number. 
IMO (rmaj == 0 && rmin < 5) makes it a lot clearer that you're testing for a
version < 0.5.

New patch in a sec with the rest of the fixes, I hope...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.