[Webkit-unassigned] [Bug 32717] Support frameset flattening

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32717





--- Comment #13 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-01-20 03:06:46 PST ---
(In reply to comment #12)
> Thanks for cleaning this up, with nice test cases too!
> 
> I wonder if we could come up with a better name for the feature than "frame
> flattening" (and as a result, for all names in the code that use it). It has
> been used for a long time but it is not very descriptive. "Expanding framesets
> to content" perhaps. How would
> 
> Settings::expandsFramesetsToContent() 
> 
> for example sound?

I don't think that makes it much clearer. Anyway, when we do a Qt API, we can
always use another name, though I think FrameSet Flattening is sufficient as
it's behaviour will have to be documented anyway.

It is also easier to talk about frameset/iframe flattening as a technique
instead of expanding framesets/iframes to their contents.

> Since this patch does not handle iframes, are you planning to have a separate
> feature flag for those?

Yes

> Some high level comments on the algorithm would be nice in the code (since you
> have figured it out), RenderFrameSet::positionFramesWithFlattening() mostly.

I can do that in a follow up patch if you would like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.