[Webkit-unassigned] [Bug 32717] Support frameset flattening

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32717





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2010-01-19 07:11:15 PST ---
Thanks for cleaning this up, with nice test cases too!

I wonder if we could come up with a better name for the feature than "frame
flattening" (and as a result, for all names in the code that use it). It has
been used for a long time but it is not very descriptive. "Expanding framesets
to content" perhaps. How would

Settings::expandsFramesetsToContent() 

for example sound?

Since this patch does not handle iframes, are you planning to have a separate
feature flag for those?

Some high level comments on the algorithm would be nice in the code (since you
have figured it out), RenderFrameSet::positionFramesWithFlattening() mostly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.