[Webkit-unassigned] [Bug 29564] [Qt] Webkit Button Size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29564





--- Comment #15 from Tor Arne Vestbø <vestbo at webkit.org>  2010-01-20 01:33:32 PST ---
(In reply to comment #14)
> It is unclear to me how we benefit from using QMacStyle instead of the macro
> definition Q_WS_MAC since we need to use Q_WS_MAC anyway to conditionally
> #include <QMacStyle> and surround any code blocks that use QMacStyle.

QMacStyle is only available on Mac, so we have to ifdef it's use to make
QtWebKit compile on other platforms. But on Mac, where the style is available,
we can make a runtime check, to see if QtWebKit is running with the Mac style
or one of the other styles (-style windows or -style plastique for example).

But that's okey, we can defer runtime stylechecks to a later patch. It has
problems of its own since we don't report the runtime style back to JS or the
DRT in any way, so layout-tests will still think they are running against
"MacIntel" for example, even though the tests are running with the
windows-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.