[Webkit-unassigned] [Bug 29564] [Qt] Webkit Button Size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 18 20:10:02 PST 2010


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #46689|0                           |1
        is obsolete|                            |
  Attachment #46882|                            |review?
               Flag|                            |

--- Comment #14 from Daniel Bates <dbates at webkit.org>  2010-01-18 20:10:00 PST ---
Created an attachment (id=46882)
 --> (https://bugs.webkit.org/attachment.cgi?id=46882)
Patch with test case

It is unclear to me how we benefit from using QMacStyle instead of the macro
definition Q_WS_MAC since we need to use Q_WS_MAC anyway to conditionally
#include <QMacStyle> and surround any code blocks that use QMacStyle. So, I
have removed the changes related to QMacStyle from the patch. If we do decide
to switch to using QMacStyle, I suggest we do this in a separate bug.

Moreover, I have updated the layout test and expected results so that we do not
need platform-specific results. I chose to output a custom PASS/FAIL message
when testing the fifth button in the test case instead of outputting the height
of the button (which is platform-specific) so as to avoid the need for
platform-specific results.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list