[Webkit-unassigned] [Bug 33771] style-check script reports loads of errors on gtk2drawing.c

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33771





--- Comment #9 from Adam Barth <abarth at webkit.org>  2010-01-18 01:55:58 PST ---
> Okay, thanks, Adam.  Just to clarify, then, it seems like there are two classes
> of file exemptions:
> 
> (1) exemptions-with-warnings, e.g. files named "gtk2drawing.c"
>     and files in the folder "WebKit/qt/Api/", and
> (2) exemptions-without-warnings, e.g. all files in the "LayoutTests"
>     folder.

Yes.  Although the code calls (2) can_handle.

> If that's correct, I will make an explicit note of this in the code in my next
> patch.  Can you provide a rough rule of thumb as to which type new exemptions
> should belong to?

It's some optimization problem between the principle of least surprise and not
spamming useless information.  For example, I don't think anyone would be
surprised that the LayoutTests aren't covered and if we included a warning that
warning would be spammed on every patch.  On the other hand, it's kind of
surprising that don't have style coverage for gtk2drawing.c and that file isn't
modified that often.  That makes printing the error a better trade-off.

> For example, which type should the "JavaScriptGlue" folder
> belong to?

I'd print the warning.  I've never seen that folder changed so the spam problem
is quite low.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.