[Webkit-unassigned] [Bug 33771] style-check script reports loads of errors on gtk2drawing.c

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33771





--- Comment #8 from Chris Jerdonek <cjerdonek at webkit.org>  2010-01-18 01:35:24 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > With this fix, will the style bot still log a single error?
> 
> The style bot is smart enough to know whether there were any errors.  It looks
> at the exit code to figure out if the check passed.
> 
> > With files to exempt, I just wanted to clarify whether they should be silently
> > ignored, or if they should be skipped after logging a single line.
> 
> I put the logging in to make sure that folks using the tool know that they
> aren't getting coverage on those files.  It will show up in bugzilla if there
> are other errors caught by the bot, but it won't generate a bug post on its
> own.

Okay, thanks, Adam.  Just to clarify, then, it seems like there are two classes
of file exemptions:

(1) exemptions-with-warnings, e.g. files named "gtk2drawing.c"
    and files in the folder "WebKit/qt/Api/", and
(2) exemptions-without-warnings, e.g. all files in the "LayoutTests"
    folder.

If that's correct, I will make an explicit note of this in the code in my next
patch.  Can you provide a rough rule of thumb as to which type new exemptions
should belong to?  For example, which type should the "JavaScriptGlue" folder
belong to?

https://lists.webkit.org/pipermail/webkit-dev/2009-December/011047.html

(e-mail referencing JavaScriptGlue)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.