[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 16 08:54:59 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33096





--- Comment #32 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-16 08:54:57 PST ---
Attachment 46741 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:123:  Weird number of spaces at
line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:124:  Weird number of spaces at
line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:125:  Weird number of spaces at
line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:126:  Weird number of spaces at
line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:42: 
qt_drt_setTimelineProfilingEnabled is incorrectly named. Don't use underscores
in your identifier names.  [readability/naming] [4]
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:50: 
qt_drt_webinspector_executeScript is incorrectly named. Don't use underscores
in your identifier names.  [readability/naming] [4]
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:51: 
qt_drt_webinspector_show is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:52: 
qt_drt_webinspector_close is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
Total errors found: 8

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list