[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33096





--- Comment #33 from Andras Becsi <abecsi at inf.u-szeged.hu>  2010-01-16 10:07:32 PST ---
(In reply to comment #31)
> Created an attachment (id=46741)
 --> (https://bugs.webkit.org/attachment.cgi?id=46741) [details]
> Updated Patch
Great work!
There are some occasional crashes on the test bot (1 out of 100 runs) but these
may be related to other bugs Eric mentioned.
Please update the changelog text now that you did not implement display().
And also, please use 4-space indent (not 3) as the style-bot pointed out:

(In reply to comment #32)
> Attachment 46741 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:123:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:124:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:125:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:126:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.