[Webkit-unassigned] [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 5 09:43:00 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=33178
--- Comment #32 from Yong Li <yong.li.webkit at gmail.com> 2010-01-05 09:42:59 PST ---
(In reply to comment #31)
> (From update of attachment 45900 [details])
> > - unsigned bytesToCopy = static_cast<unsigned>(length) < segmentFreeSpace ? static_cast<unsigned>(length) : segmentFreeSpace;
> > + unsigned bytesToCopy = std::min(length, segmentFreeSpace);
>
> Our style is to put "using namespace std;" at the top of the file and then omit
> the "std::" qualifier.
>
> Other than that, this looks good.
>
> r=me if you fix that before committing.
thanks. doing it now
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list