[Webkit-unassigned] [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 09:35:16 PST 2010


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
  Attachment #45900|review?                     |review+
               Flag|                            |

--- Comment #31 from Adam Roben (aroben) <aroben at apple.com>  2010-01-05 09:35:14 PST ---
(From update of attachment 45900)
> -    unsigned bytesToCopy = static_cast<unsigned>(length) < segmentFreeSpace ? static_cast<unsigned>(length) : segmentFreeSpace;
> +    unsigned bytesToCopy = std::min(length, segmentFreeSpace);

Our style is to put "using namespace std;" at the top of the file and then omit
the "std::" qualifier.

Other than that, this looks good.

r=me if you fix that before committing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list