[Webkit-unassigned] [Bug 35265] run-chromium-webkit-tests --platform=mac-leopard diffs are backwards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35265





--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-02-25 14:11:03 PST ---
(In reply to comment #4)
> > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py
> > -    def diff_text(self, actual_text, expected_text,
> > -                  actual_filename, expected_filename):
> > +    def diff_text(self, expected_text, actual_text,
> > +            expected_filename, actual_filename):
> It would be nice to align to the ( of the previous line (as was done before).

I thought "we" as webkit avoided that because you end up having to re-indent
all the time.  I went with the "just indent one level" model.  Does PEP8 say
anything on this subject?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.