[Webkit-unassigned] [Bug 35265] run-chromium-webkit-tests --platform=mac-leopard diffs are backwards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35265


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49441|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from David Levin <levin at chromium.org>  2010-02-25 09:03:00 PST ---
(From update of attachment 49441)
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +2010-02-24  Eric Seidel  <eric at webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        run-chromium-webkit-tests --platform=mac-leopard diffs are backwards
> +        https://bugs.webkit.org/show_bug.cgi?id=35265
> +
> +        Some parts of the code passed arguments as
> +        "actual, expected" and some passed as "expected, actual".
> +        As you might imagine, this lead to great confusion and wrongness.
> +        Standardize on "expected, actual" as that't the order which is

typo: that't

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py
> -    def diff_text(self, actual_text, expected_text,
> -                  actual_filename, expected_filename):
> +    def diff_text(self, expected_text, actual_text,
> +            expected_filename, actual_filename):
It would be nice to align to the ( of the previous line (as was done before).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.