[Webkit-unassigned] [Bug 35146] [Qt] Support tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35146





--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-25 10:14:39 PST ---
(From update of attachment 49491)
Ah nice, it is getting there! So what is missing before you are ready to put
this up for review?

Some quick comments.

> +    const IntRect rectToContents() const;

Is this a mapping function? what about mapToContents?


> +
> +    // FIXME: In single threaded case, tile backbuffers could be updated asynchrnously 

Spelling issue :-)


> +PassRefPtr<Tile> TiledBackingStore::tile(const Tile::Coordinate& coordinate) const
> +{

tileAt?


> +IntRect TiledBackingStore::rectToContents(const IntRect& rect) const

mapRectToContents? mapToContents?

> +bool QGraphicsWebView::tiledBackingStoreFrozen() const

Could you add documentation with \since 4.6 to these public methods?

Also, add a 'is' in front.  isTiledBackingStoreFrozen()


> Index: WebKit/qt/QGVLauncher/main.cpp

QGVLauncher was removed as far as I know. You should add the code to QtLauncher
instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.