[Webkit-unassigned] [Bug 35328] [Qt] Various Fixes to MediaPlayerPrivateQt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35328





--- Comment #3 from Nick Young <nicholas.young at nokia.com>  2010-02-24 17:16:46 PST ---
(In reply to comment #2)
> Instead of using the element to get to the frame and document, you can use
> MediaPlayer's frameView().

That's what I used to have, it doesn't work.

This is dependent on a renderer being created for the video element before we
hit load(). This is not always the case.

Check out this example:
http://people.freedesktop.org/~company/stuff/video-demo.html

In this example, a renderer is NEVER created for these videos because they are
never added to the document. The demo still works as expected, but
MediaPlayer::frameView() will always return NULL.

Perhaps there is room for MediaPlayerClient::mediaPlayerOwningDocument(), or
something like that?

> It looks like bufferStatus() return the percent loaded. Shouldn't you multiply
> this by the resource size here to get bytes loaded?

Sure. I'm wasn't too worried about this method because we don't actually use it
anywhere, but for the sake of implementing the interface properly, I'll do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.