[Webkit-unassigned] [Bug 35328] [Qt] Various Fixes to MediaPlayerPrivateQt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35328


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49358|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2010-02-24 07:29:30 PST ---
(From update of attachment 49358)

> +        // Grab the client media element
> +        HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_player->mediaPlayerClient());
> +
>          // Grab the current document
>          Document* document = element->document();
>          if (!document)

Instead of using the element to get to the frame and document, you can use
MediaPlayer's frameView().


>      QLatin1String bytesLoadedKey("bytes-loaded");
>      if (m_mediaPlayer->availableExtendedMetaData().contains(bytesLoadedKey))
>          return m_mediaPlayer->extendedMetaData(bytesLoadedKey).toInt();
>  
> -    return percentage;
> +    return m_mediaPlayer->bufferStatus();

It looks like bufferStatus() return the percent loaded. Shouldn't you multiply
this by the resource size here to get bytes loaded?

r=me with these changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.