[Webkit-unassigned] [Bug 35191] [Gtk] use geoclue providers with don't provide update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35191


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49322|review?                     |review-
               Flag|                            |




--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-23 14:57:57 PST ---
(From update of attachment 49322)
 8         No new tests. (OOPS!)

You should state here that there's no testable behaviour change, (I assume
there isn't because this depends on the system). Also, you're not doing only
what you claim in the changelog, in this patch. You're also making updating the
location information async, which does sound like a good idea, but should be
made into another patch. r- for that reason.

Also, we had many crashes happen because the WebCore object goes away between
an async call, and its callback returning, so passin 'this' here worries me:

 118     geoclue_position_get_position_async(m_geocluePosition,
(GeocluePositionCallback)get_position, this);

Have you checked what the life cycle of the geolocation service object is, and
if it will react well if its client goes away?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.