[Webkit-unassigned] [Bug 35191] [Gtk] use geoclue providers with don't provide update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35191


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gns at gnome.org




--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-23 14:27:04 PST ---
(In reply to comment #2)
> Also, I've a question about GeolocationServiceGtk::startUpdating code:
> 
> 
> g_error_free is not called after
> 
> 
>     if (!result) {
>         setError(PositionError::POSITION_UNAVAILABLE, error->message)
> 
> Is it because of some GOwnPtr magic ?

Yes. GOwnPtr knows that the reference is only relevant inside that scope, so
when the function is done it will free the pointer. Here's GError's
specialization of the template:

template <> void freeOwnedGPtr<GError>(GError* ptr)
{
    if (ptr)
        g_error_free(ptr);
}

You can see more details at JavaScriptCore/wtf/gobject/GOwnPtr.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.