[Webkit-unassigned] [Bug 35287] ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 12:14:46 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35287





--- Comment #6 from Mark Rowe (bdash) <mrowe at apple.com>  2010-02-23 12:14:46 PST ---
(In reply to comment #4)
> (From update of attachment 49304 [details])
> > +    // source (<rdar://problem/7679174>).  We work around this by special-casing all frames except the
> 
> We do a single space after periods.

Perhaps we should put this in the style guide ;-)

> > +    if (index < frameCount() - 1)
> > +        return frameStatus >= kCGImageStatusIncomplete;
> 
> Can this ever be called if the frameCount is 0?

It can’t be called with a frameCount of zero.  I’ll add an assertion that
frameCount is not zero since the code doesn’t correctly handle that case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list