[Webkit-unassigned] [Bug 35287] ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35287





--- Comment #5 from Mark Rowe (bdash) <mrowe at apple.com>  2010-02-23 12:10:58 PST ---
(In reply to comment #3)
> (From update of attachment 49304 [details])
> It looks like the two values we're interested in, when testing "frameStatus >=
> kCGImageStatusIncomplete", are:
>     kCGImageStatusIncomplete = -1,
>     kCGImageStatusComplete = 0
> 
> I think it would be better just to test them explicitly: "frameStatus ==
> kCGImageStatusIncomplete || frameStatus == kCGImageStatusComplete".
> 
> This has the benefit of documenting which values we're testing for without
> requiring the reader to flip to another file. Also, unless there's some
> explicit API contract somewhere, it's probably better not to assume that
> statuses >= kCGImageStatusIncomplete will always be "good" statuses.

I was matching the manner in which the status values are tested elsewhere in
ImageSourceCG.cpp:
<http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/cg/ImageSourceCG.cpp#L153>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.