[Webkit-unassigned] [Bug 31589] [Qt] Add support for layout tests on Symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31589





--- Comment #9 from Simon Hausmann <hausmann at webkit.org>  2010-02-22 10:04:49 PST ---
(From update of attachment 49127)

> -#ifndef Q_OS_WIN
> +#if HAVE(SIGNAL_H)
>  static NO_RETURN void crashHandler(int sig)
>  {
>      fprintf(stderr, "%s\n", strsignal(sig));
> @@ -132,7 +132,7 @@ int main(int argc, char* argv[])
>      QX11Info::setAppDpiX(0, 96);
>  #endif
>  
> -#ifndef Q_OS_WIN
> +#if HAVE(SIGNAL_H)
>      signal(SIGILL, crashHandler);    /* 4:   illegal instruction (not reset when caught) */
>      signal(SIGTRAP, crashHandler);   /* 5:   trace trap (not reset when caught) */
>      signal(SIGFPE, crashHandler);    /* 8:   floating point exception */

I'm unsure about these two hunks. HAVE(SIGNAL_H) comes from the WTF includes
that we should not use outside of JavaScriptCore/WebCore. Are you sure that the
above HAVE macros evaluate to true on Linux, even though main.cpp isn't
directly including config.h? I'm worried that they'll now always evaluate to
false, which will make the code still compile and run, but we won't get crash
detection.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.