[Webkit-unassigned] [Bug 31589] [Qt] Add support for layout tests on Symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31589





--- Comment #10 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-02-22 10:46:09 PST ---
> I'm unsure about these two hunks. HAVE(SIGNAL_H) comes from the WTF includes
> that we should not use outside of JavaScriptCore/WebCore.

I agree; filed a bug https://bugs.webkit.org/show_bug.cgi?id=35248.

> Are you sure that the
> above HAVE macros evaluate to true on Linux, even though main.cpp isn't
> directly including config.h? 

main.cpp includes wtf/AlwaysInline.h, which includes Platform.h.

> I'm worried that they'll now always evaluate to
> false, which will make the code still compile and run, but we won't get crash
> detection.

I double-checked and crash detection gets compiled on Linux.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.