[Webkit-unassigned] [Bug 34782] Normalize custom ctors for Image, Option, Audio

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 11:25:35 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34782





--- Comment #13 from Alexey Proskuryakov <ap at webkit.org>  2010-02-18 11:25:35 PST ---
+    // Calling toJS on the document causes the JS document wrapper to be
+    // added to the window object. This is done to ensure that
JSDocument::markChildren
+    // will be called, which will cause the audio element to be marked if
necessary.
+    // FIXME: The correct way to do this would be to make HTMLMediaElement
derive from
+    // ActiveDOMObject and use its interface to keep its wrapper alive. Then
we would
+    // remove this code and the special case in isObservableThroughDOM.

Active DOM objects are marked from JSDocument::markChildren, so it seems that
we would still need a document wrapper.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list