[Webkit-unassigned] [Bug 34782] Normalize custom ctors for Image, Option, Audio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34782


Yaar Schnitman <yaar at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49032|                            |commit-queue?
               Flag|                            |




--- Comment #12 from Yaar Schnitman <yaar at chromium.org>  2010-02-18 11:14:16 PST ---
(From update of attachment 49032)
1. Darin and my patches are merged.
2. I adopted the createForJSConstructor naming.
3. Re: FIXME: always appending a text node to option: I think this is the right
behavior for backward compatibility reasons and because option is quite useless
without a text node with its content.
4. I liked the use of pointers for optional args, but I think it will make
future auto-generation of the ctors too complex. Instead, I use default values.
We can rethink this once the code-generation is fixed.
5. Added a layout test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.